-
Notifications
You must be signed in to change notification settings - Fork 186
Merge data.extended.json into data.json #3341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, I'd very much like to get the extended data into the web-features
package and I'm supportive. That said, I've got two main suggestions here (more detail in line comments):
- I'd prefer to change the way we generate
data.json
so that it's equivalent todata.extended.json
. I think the one and only place we should have adata.extended.json
is in the GitHub release artifacts (so that anyone depending on that URL still gets the data, at least until our next breaking release). - I'd prefer to introduce utility functions separately. I think there's more discussion to have on that front and I don't want it to block providing the full data set.
Oh, one more thing: I pretty sure web-features/schemas/data.schema.json Lines 300 to 308 in 5e81ac2
|
I tried this, but |
Progress on #3060
by_compat_key
data as part of the mainindex
script for data.json