Implement parsing of Link HTTP headers #53855
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Link HTTP header can do the same as link elements, in that they can preload/prefetch/etc... This implements the basics of header parsing and hooks it up for preload. Note that we use a new nom-rfc8288 crate that implements the parsing behavior. However, that crate is too strict in that empty attributes (`;;` as part of the header) are discarded and resulting in a parsing failure. I temporarily edited the WPT infrastructure to make our tests run, but that needs to be reverted before merging when the crate is updated to handle these cases correctly. Part of web-platform-tests#35035 Signed-off-by: Tim van der Lippe <[email protected]>
wpt-pr-bot
approved these changes
Jul 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Link HTTP header can do the same as link elements,
in that they can preload/prefetch/etc... This implements
the basics of header parsing and hooks it up for preload.
Note that we use a new nom-rfc8288 crate that implements
the parsing behavior. However, that crate is too strict
in that empty attributes (
;;as part of the header) arediscarded and resulting in a parsing failure. I temporarily
edited the WPT infrastructure to make our tests run, but
that needs to be reverted before merging when the crate
is updated to handle these cases correctly.
Part of #35035
Reviewed in servo/servo#38175