Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Conversation

@spacesailor24
Copy link
Contributor

Fixed

Changed

@render
Copy link

render bot commented Sep 10, 2021

@coveralls
Copy link

coveralls commented Sep 10, 2021

Pull Request Test Coverage Report for Build 1260452621

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 422 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-2.6%) to 72.915%

Files with Coverage Reduction New Missed Lines %
packages/web3-core-requestmanager/src/jsonrpc.js 1 88.0%
packages/web3-core-helpers/src/formatters.js 24 80.65%
packages/web3-core-helpers/src/errors.js 31 4.41%
packages/web3-utils/src/soliditySha3.js 55 5.13%
packages/web3-utils/src/index.js 62 29.31%
packages/web3-utils/src/utils.js 85 13.04%
packages/web3-eth-accounts/src/index.js 164 25.31%
Totals Coverage Status
Change from base Build 1222417029: -2.6%
Covered Lines: 3324
Relevant Lines: 4310

💛 - Coveralls

@spacesailor24
Copy link
Contributor Author

As part of the RC process, am doing some test installations in other projects and running their tests to see if everything.

  • installs properly
  • builds
  • tests pass
Project Desc Status
oz-test-helpers Test utils. Subset of their suite is web3 contracts
synthetix ~1000 units

nazarhussain
nazarhussain previously approved these changes Sep 21, 2021
luu-alex
luu-alex previously approved these changes Sep 21, 2021
@spacesailor24 spacesailor24 dismissed stale reviews from luu-alex and nazarhussain via c82db7a September 22, 2021 05:13
@spacesailor24 spacesailor24 changed the title v1.5.3-rc.0 v1.5.3 Sep 22, 2021
@spacesailor24 spacesailor24 marked this pull request as ready for review September 22, 2021 05:13
@spacesailor24 spacesailor24 merged commit 7e10eb4 into 1.x Sep 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

1.x 1.0 related issues Release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants