fix(plugin-meetings): add space_share call type to isMeetingActive #4045
Conversation
📝 WalkthroughWalkthroughThe pull request introduces a new constant Possibly related PRs
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 ESLint
yarn install v1.22.22 (For a CapTP with native promises, see @endo/eventual-send and @endo/captp) 📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
shnaaz
left a comment
shnaaz
left a comment
There was a problem hiding this comment.
Tested this with Canitna, this looks good and fixes space_share issue
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/@webex/plugin-meetings/test/unit/spec/locus-info/index.js (1)
2645-2707: Well-structured test cases with good coverage.The test cases effectively verify the
isMeetingActivefunction for all call types including the new_SPACE_SHARE_type. The use offorEachto test multiple call types reduces code duplication and ensures consistent testing across all types.However, consider adding the following test cases to improve coverage:
- Edge cases where the type is undefined/null
- Cases where the state transitions from active to inactive
Example test case:
it('handles undefined type correctly', () => { locusInfo.parsedLocus = { fullState: { type: undefined, }, }; locusInfo.fullState = { state: LOCUS.STATE.INACTIVE, }; locusInfo.isMeetingActive(); assert.calledWith(webex.internal.newMetrics.submitClientEvent, { name: 'client.call.remote-ended', options: { meetingId: locusInfo.meetingId, }, }); });
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
packages/@webex/plugin-meetings/src/constants.ts(1 hunks)packages/@webex/plugin-meetings/src/locus-info/index.ts(2 hunks)packages/@webex/plugin-meetings/test/unit/spec/locus-info/index.js(5 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
- packages/@webex/plugin-meetings/src/locus-info/index.ts
- packages/@webex/plugin-meetings/src/constants.ts
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Build Packages
- GitHub Check: AWS Amplify Console Web Preview
🔇 Additional comments (1)
packages/@webex/plugin-meetings/test/unit/spec/locus-info/index.js (1)
26-27: LGTM! Good addition of the new constants.The import statement correctly adds the required constants
_SIP_BRIDGE_and_SPACE_SHARE_for the test cases.
3 participants
COMPLETES SPARK-457095
This pull request addresses
Stale meeting remaining after a 1-1 Screen share has ended
by making the following changes
Adds support for the
space_sharemeeting type toisMeetingActiveChange Type
The following scenarios were tested
I certified that
Make sure to have followed the contributing guidelines before submitting.