fix: updated metric to only send for error/triaging purposes

[johnsoter13]

COMPLETES #< https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-651771 >

This pull request addresses

• Issue where client is sending way too many metric events ie: https://logs.o.webex.com/app/discover#/view/bb611660-1ddf-11f0-ba69-a9259937da9c?_g=h@8cf8006&_a=h@4dce3e8

by making the following changes

• Only making requests for this type when there is an error. No analysis is done using this event so it's only useful for error triaging anyway

Change Type

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation update
• Tooling change
• Internal code refactor

The following scenarios were tested

< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

I certified that

• I have read and followed contributing guidelines

• I discussed changes with code owners prior to submitting this pull request

• I have not skipped any automated checks

• All existing and new tests passed

• I have updated the documentation accordingly

---

Make sure to have followed the contributing guidelines before submitting.

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes remove the submission of specific client metric events related to RoapMessage requests and responses within the sendHttpRequest method of locusMediaRequest.ts. Specifically, the code that previously submitted 'client.locus.media.request' and 'client.locus.media.response' events when handling RoapMessage types has been deleted. The error-path event submission remains intact. Correspondingly, in the test suite, the helper function checkMetrics—which verified the presence or absence of these metric events—has been removed, along with all its invocations in the relevant test cases. No other logic, control flow, or public API has been altered in either the implementation or the tests.

Possibly related PRs

• fix(plugin-meetings): extra logging of roap messages progress #4135: Adds progress event emitters and logging for RoapMessage requests in locusMediaRequest.ts, modifying the handling of RoapMessage requests in the same file as this PR, but focusing on progress events rather than metric submissions.

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f5ac0c7 and 5a6df3c.

📒 Files selected for processing (2)

• packages/@webex/plugin-meetings/src/meeting/locusMediaRequest.ts (0 hunks)
• packages/@webex/plugin-meetings/test/unit/spec/meeting/locusMediaRequest.ts (0 hunks)

💤 Files with no reviewable changes (2)

• packages/@webex/plugin-meetings/test/unit/spec/meeting/locusMediaRequest.ts
• packages/@webex/plugin-meetings/src/meeting/locusMediaRequest.ts

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: Initialize Project
• GitHub Check: AWS Amplify Console Web Preview

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[aws-amplify-us-east-2]

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-4217.d3m3l2kee0btzx.amplifyapp.com