fix(taskManager): added-agent-invite-failed-event #4262
Conversation
📝 WalkthroughWalkthroughA new event constant, Possibly related PRs
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
yarn install v1.22.22 (For a CapTP with native promises, see @endo/eventual-send and @endo/captp) Tip ⚡️ Faster reviews with caching
Enjoy the performance boost—your workflow just got faster. 📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms (2)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Shreyas281299
added
the
validated
|
@CodeRabbit review |
✅ Actions performedReview triggered.
|
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
|
I noticed a flicker in the vidcast when task list came in... is it possible to remove that? |
| task.emit(TASK_EVENTS.TASK_REJECT, payload.data.reason); | ||
| break; | ||
| case CC_EVENTS.CONTACT_ENDED: | ||
| case CC_EVENTS.AGENT_INVITE_FAILED: |
There was a problem hiding this comment.
We might need to emit an event here and so create a TASK_EVENTS.AGENT_INVITE_FAILED ... then we might need to listen to that also.
There was a problem hiding this comment.
For now this also comes under contact_ended before even answer so we can combine CC_EVENTS.CONTACT_ENDED and CC_EVENTS.AGENT_INVITE_FAILED
Thanks for pointing that out! This is the current behavior we’ve captured on the CC Widgets side. We’ll look into it and explore a feasible solution to smooth out the flicker. |
adhmenon
left a comment
adhmenon
left a comment
There was a problem hiding this comment.
LGTM. As per our discussion, let us ensure that we solve the flicker issue we see in widgets for this also. Till then we should not update the SDK version.
Sure |
4 participants
COMPLETES #< INSERT LINK TO ISSUE >
This pull request addresses
This pull request addresses while testing extension login, the agent is not logged in to receive the extension call. However, tasks are still appearing in the Task List section. This indicates that the task list is not being cleared appropriately when the agent is not logged in
Jira Link: https://jira-eng-sjc12.cisco.com/jira/browse/CAI-6290
Vidcast Link: https://app.vidcast.io/share/bf243e05-8317-4ace-9217-db463376d373
by making the following changes
Added an event called AgentInviteFailed to ensure the Task List is cleared when the agent is not logged in. This prevents tasks from appearing in the list if the agent is not authenticated, maintaining consistency with the agent's login state
After the fix
Before the fix
Test Results:
Change Type
The following scenarios were tested
Tested locally on the CC Widgets side by connecting to the local Webex-js-sdk with the AgentInviteFailed event changes. Attached below is the Vidcast that captures the behavior.
Vidcast Link: https://app.vidcast.io/share/bf243e05-8317-4ace-9217-db463376d373
The GAI Coding Policy And Copyright Annotation Best Practices
I certified that
Make sure to have followed the contributing guidelines before submitting.