feat(appai): attendee email is required case, metrics data need set c… #4331
Conversation
…ategory as expected
📝 WalkthroughWalkthroughA new entry was added to the SERVICE_ERROR_CODES_TO_CLIENT_ERROR_CODES_MAP object in the call-diagnostic/config.ts file. Specifically, the service error code 403030 is now mapped to the client error code 4101, with a comment indicating this error occurs when an attendee email is required. No other logic, error handling, or exported/public entity declarations were changed. Possibly related PRs
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
yarn install v1.22.22 (For a CapTP with native promises, see @endo/eventual-send and @endo/captp) ✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/@webex/internal-plugin-metrics/src/call-diagnostic/config.ts (1)
226-227: Add unit test for attendee-email-required mapping
To ensure this scenario remains covered, please add a unit test that asserts:SERVICE_ERROR_CODES_TO_CLIENT_ERROR_CODES_MAP[403030] === 4101 CLIENT_ERROR_CODE_TO_ERROR_PAYLOAD[4101].category === 'expected' CLIENT_ERROR_CODE_TO_ERROR_PAYLOAD[4101].errorDescription === ERROR_DESCRIPTIONS.USER_NOT_ALLOWED_ACCESS_MEETING
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/@webex/internal-plugin-metrics/src/call-diagnostic/config.ts(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: AWS Amplify Console Web Preview
🔇 Additional comments (1)
packages/@webex/internal-plugin-metrics/src/call-diagnostic/config.ts (1)
226-227: Mapping entry approved
The new mapping of service error code403030to client error code4101correctly captures the "Attendee email is required" condition and will surface it with an 'expected' category in metrics.
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
3 participants
COMPLETES #< INSERT LINK TO ISSUE >
This pull request addresses
< DESCRIBE THE CONTEXT OF THE ISSUE >
attendee email is required case, metrics data need set category as expected
by making the following changes
< DESCRIBE YOUR CHANGES >
Change Type
The following scenarios were tested
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >
The GAI Coding Policy And Copyright Annotation Best Practices
I certified that
Make sure to have followed the contributing guidelines before submitting.