feat(contact-center): rename plugin-cc to contact-center #4417
Conversation
…ack config for cdn bundle
📝 WalkthroughWalkthroughThis change updates the package name and related references for the Webex contact center plugin, transitioning from "@webex/plugin-cc" to "@webex/contact-center". The updates include changes to package metadata, internal documentation, import paths, dependency lists, build configuration, and scripts. The webpack configuration is modified to use dynamic output filenames and updated paths reflecting the new package structure. Documentation files, example code comments, and README content are updated to reflect the new package name. No functional code logic or exported/public entity declarations are altered. Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🔭 Outside diff range comments (1)
packages/@webex/contact-center/package.json (1)
35-37: Engine requirement jumps to Node 20 – verify repo-wide consistencyOther workspaces (e.g.,
packages/webex) still declare"node": ">=16". Installing the monorepo under Node 18 will now fail because of this package. Align engine ranges across packages or document the new minimum version.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (21)
docs/samples/calling.min.jsis excluded by!**/*.min.jsdocs/samples/calling.min.js.mapis excluded by!**/*.map,!**/*.min.js.mapdocs/samples/contact-center.min.jsis excluded by!**/*.min.jsdocs/samples/contact-center.min.js.mapis excluded by!**/*.map,!**/*.min.js.mapdocs/samples/encryption.min.jsis excluded by!**/*.min.jsdocs/samples/encryption.min.js.mapis excluded by!**/*.map,!**/*.min.js.mapdocs/samples/meetings.min.jsis excluded by!**/*.min.jsdocs/samples/meetings.min.js.mapis excluded by!**/*.map,!**/*.min.js.mapdocs/samples/webex.min.jsis excluded by!**/*.min.jsdocs/samples/webex.min.js.mapis excluded by!**/*.map,!**/*.min.js.mappackages/@webex/contact-center/umd/contact-center.min.jsis excluded by!**/*.min.jspackages/@webex/contact-center/umd/contact-center.min.js.mapis excluded by!**/*.map,!**/*.min.js.mappackages/webex/umd/calling.min.jsis excluded by!**/*.min.jspackages/webex/umd/calling.min.js.mapis excluded by!**/*.map,!**/*.min.js.mappackages/webex/umd/encryption.min.jsis excluded by!**/*.min.jspackages/webex/umd/encryption.min.js.mapis excluded by!**/*.map,!**/*.min.js.mappackages/webex/umd/meetings.min.jsis excluded by!**/*.min.jspackages/webex/umd/meetings.min.js.mapis excluded by!**/*.map,!**/*.min.js.mappackages/webex/umd/webex.min.jsis excluded by!**/*.min.jspackages/webex/umd/webex.min.js.mapis excluded by!**/*.map,!**/*.min.js.mapyarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (6)
packages/@webex/contact-center/package.json(2 hunks)packages/@webex/contact-center/src/services/task/constants.ts(1 hunks)packages/@webex/contact-center/src/webex.js(1 hunks)packages/webex/package.json(1 hunks)packages/webex/src/webex.js(1 hunks)webpack.config.js(2 hunks)
🧰 Additional context used
🧠 Learnings (7)
📓 Common learnings
Learnt from: robstax
PR: webex/webex-js-sdk#3948
File: packages/@webex/webex-core/test/unit/spec/webex-core.js:178-254
Timestamp: 2024-11-01T00:30:53.442Z
Learning: In the webex-js-sdk project, when reviewing changes in `packages/@webex/webex-core/test/unit/spec/webex-core.js`, if the user declines to add negative test cases for invalid interceptor configurations, accept their decision and do not insist.
Learnt from: Kesari3008
PR: webex/webex-js-sdk#4258
File: packages/@webex/plugin-cc/src/webex.js:0-0
Timestamp: 2025-05-13T17:01:05.340Z
Learning: In the webex-js-sdk project, `PACKAGE_VERSION` is a constant that's injected by the build system and doesn't need to be explicitly imported in the source files.
Learnt from: pagour98
PR: webex/webex-js-sdk#4086
File: packages/@webex/plugin-cc/test/unit/spec/services/task/dialer.ts:52-57
Timestamp: 2025-02-12T10:13:06.265Z
Learning: In packages/@webex/plugin-cc tests, catch blocks in test cases follow CC Desktop pattern using `expect(true).toBe(true)` for consistency.
packages/@webex/contact-center/src/webex.js (6)
Learnt from: Kesari3008
PR: #4258
File: packages/@webex/plugin-cc/src/webex.js:0-0
Timestamp: 2025-05-13T17:01:05.340Z
Learning: In the webex-js-sdk project, PACKAGE_VERSION is a constant that's injected by the build system and doesn't need to be explicitly imported in the source files.
Learnt from: robstax
PR: #3948
File: packages/@webex/webex-core/test/unit/spec/webex-core.js:178-254
Timestamp: 2024-11-01T00:30:53.442Z
Learning: In the webex-js-sdk project, when reviewing changes in packages/@webex/webex-core/test/unit/spec/webex-core.js, if the user declines to add negative test cases for invalid interceptor configurations, accept their decision and do not insist.
Learnt from: pagour98
PR: #4086
File: packages/@webex/plugin-cc/test/unit/spec/services/task/dialer.ts:52-57
Timestamp: 2025-02-12T10:13:06.265Z
Learning: In packages/@webex/plugin-cc tests, catch blocks in test cases follow CC Desktop pattern using expect(true).toBe(true) for consistency.
Learnt from: pagour98
PR: #4086
File: docs/samples/contact-center/index.html:226-237
Timestamp: 2025-02-12T10:21:39.427Z
Learning: Accessibility improvements are not required for sample applications in the webex-js-sdk repository, as these apps primarily focus on demonstrating core functionality.
Learnt from: bhabalan
PR: #4022
File: docs/samples/contact-center/app.js:116-118
Timestamp: 2024-12-06T12:48:03.643Z
Learning: In docs/samples/contact-center/app.js, hardcoding the OAuth client ID and secret is acceptable for testing purposes in an isolated sandbox environment.
Learnt from: rsarika
PR: #4098
File: packages/calling/src/Logger/index.ts:0-0
Timestamp: 2025-02-14T09:43:31.759Z
Learning: In the Webex JS SDK's Logger module, the console is used as the default logger fallback when no custom logger is provided, making extensive logger validation unnecessary. A simple existence check if (logger) is sufficient when setting a custom logger.
packages/webex/src/webex.js (4)
Learnt from: Kesari3008
PR: #4258
File: packages/@webex/plugin-cc/src/webex.js:0-0
Timestamp: 2025-05-13T17:01:05.340Z
Learning: In the webex-js-sdk project, PACKAGE_VERSION is a constant that's injected by the build system and doesn't need to be explicitly imported in the source files.
Learnt from: pagour98
PR: #4086
File: packages/@webex/plugin-cc/test/unit/spec/services/task/dialer.ts:52-57
Timestamp: 2025-02-12T10:13:06.265Z
Learning: In packages/@webex/plugin-cc tests, catch blocks in test cases follow CC Desktop pattern using expect(true).toBe(true) for consistency.
Learnt from: robstax
PR: #3948
File: packages/@webex/webex-core/test/unit/spec/webex-core.js:178-254
Timestamp: 2024-11-01T00:30:53.442Z
Learning: In the webex-js-sdk project, when reviewing changes in packages/@webex/webex-core/test/unit/spec/webex-core.js, if the user declines to add negative test cases for invalid interceptor configurations, accept their decision and do not insist.
Learnt from: bhabalan
PR: #4022
File: docs/samples/contact-center/app.js:116-118
Timestamp: 2024-12-06T12:48:03.643Z
Learning: In docs/samples/contact-center/app.js, hardcoding the OAuth client ID and secret is acceptable for testing purposes in an isolated sandbox environment.
packages/@webex/contact-center/src/services/task/constants.ts (2)
Learnt from: Kesari3008
PR: #4258
File: packages/@webex/plugin-cc/src/webex.js:0-0
Timestamp: 2025-05-13T17:01:05.340Z
Learning: In the webex-js-sdk project, PACKAGE_VERSION is a constant that's injected by the build system and doesn't need to be explicitly imported in the source files.
Learnt from: rarajes2
PR: #4089
File: packages/@webex/plugin-cc/src/services/task/TaskManager.ts:68-72
Timestamp: 2025-02-12T05:38:57.958Z
Learning: In the TaskManager class of @webex/plugin-cc, error handling is handled at a higher level and individual case blocks in the switch statement don't require explicit try-catch blocks to maintain consistency across all cases.
packages/webex/package.json (4)
Learnt from: Kesari3008
PR: #4258
File: packages/@webex/plugin-cc/src/webex.js:0-0
Timestamp: 2025-05-13T17:01:05.340Z
Learning: In the webex-js-sdk project, PACKAGE_VERSION is a constant that's injected by the build system and doesn't need to be explicitly imported in the source files.
Learnt from: robstax
PR: #3948
File: packages/@webex/webex-core/test/unit/spec/webex-core.js:178-254
Timestamp: 2024-11-01T00:30:53.442Z
Learning: In the webex-js-sdk project, when reviewing changes in packages/@webex/webex-core/test/unit/spec/webex-core.js, if the user declines to add negative test cases for invalid interceptor configurations, accept their decision and do not insist.
Learnt from: pagour98
PR: #4086
File: packages/@webex/plugin-cc/test/unit/spec/services/task/dialer.ts:52-57
Timestamp: 2025-02-12T10:13:06.265Z
Learning: In packages/@webex/plugin-cc tests, catch blocks in test cases follow CC Desktop pattern using expect(true).toBe(true) for consistency.
Learnt from: bhabalan
PR: #4022
File: docs/samples/contact-center/app.js:116-118
Timestamp: 2024-12-06T12:48:03.643Z
Learning: In docs/samples/contact-center/app.js, hardcoding the OAuth client ID and secret is acceptable for testing purposes in an isolated sandbox environment.
packages/@webex/contact-center/package.json (4)
Learnt from: Kesari3008
PR: #4258
File: packages/@webex/plugin-cc/src/webex.js:0-0
Timestamp: 2025-05-13T17:01:05.340Z
Learning: In the webex-js-sdk project, PACKAGE_VERSION is a constant that's injected by the build system and doesn't need to be explicitly imported in the source files.
Learnt from: pagour98
PR: #4086
File: packages/@webex/plugin-cc/test/unit/spec/services/task/dialer.ts:52-57
Timestamp: 2025-02-12T10:13:06.265Z
Learning: In packages/@webex/plugin-cc tests, catch blocks in test cases follow CC Desktop pattern using expect(true).toBe(true) for consistency.
Learnt from: pagour98
PR: #4086
File: docs/samples/contact-center/index.html:226-237
Timestamp: 2025-02-12T10:21:39.427Z
Learning: Accessibility improvements are not required for sample applications in the webex-js-sdk repository, as these apps primarily focus on demonstrating core functionality.
Learnt from: bhabalan
PR: #4022
File: docs/samples/contact-center/app.js:116-118
Timestamp: 2024-12-06T12:48:03.643Z
Learning: In docs/samples/contact-center/app.js, hardcoding the OAuth client ID and secret is acceptable for testing purposes in an isolated sandbox environment.
webpack.config.js (3)
Learnt from: Kesari3008
PR: #4258
File: packages/@webex/plugin-cc/src/webex.js:0-0
Timestamp: 2025-05-13T17:01:05.340Z
Learning: In the webex-js-sdk project, PACKAGE_VERSION is a constant that's injected by the build system and doesn't need to be explicitly imported in the source files.
Learnt from: robstax
PR: #3948
File: packages/@webex/webex-core/test/unit/spec/webex-core.js:178-254
Timestamp: 2024-11-01T00:30:53.442Z
Learning: In the webex-js-sdk project, when reviewing changes in packages/@webex/webex-core/test/unit/spec/webex-core.js, if the user declines to add negative test cases for invalid interceptor configurations, accept their decision and do not insist.
Learnt from: pagour98
PR: #4086
File: packages/@webex/plugin-cc/test/unit/spec/services/task/dialer.ts:52-57
Timestamp: 2025-02-12T10:13:06.265Z
Learning: In packages/@webex/plugin-cc tests, catch blocks in test cases follow CC Desktop pattern using expect(true).toBe(true) for consistency.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: AWS Amplify Console Web Preview
🔇 Additional comments (6)
packages/@webex/contact-center/src/services/task/constants.ts (1)
3-3: Header annotation correctly updated to new scopeThe module path now reflects the renamed package. No further action needed.
packages/@webex/contact-center/src/webex.js (1)
56-63: Example import paths align with the new package nameThe quick-start snippets now reference
@webex/contact-center. Looks good.packages/webex/package.json (1)
71-71: Dependency switch validated
@webex/contact-centerreplaces the obsolete package independencies; nothing else changed.packages/@webex/contact-center/package.json (1)
2-8: Restrictive publish list is sensible but double-check build outputPublishing only
distandumdis fine as long as the build actually emits both folders.webpack.config.js (2)
58-58: LGTM! Import path correctly updated for package rename.The import path has been properly updated from
@webex/plugin-ccto@webex/contact-centerto align with the package rename.
68-75: Confirm UMD output path structure
We’ve verified that the dynamic filename logic in webpack.config.js (lines 68–75) produces the following outputs and matches existing directories:
- Contact Center UMD: packages/@webex/contact-center/umd/[name].min.js (dir exists)
- Other UMD: packages/webex/umd/[name].min.js (dir exists)
- Non-UMD: docs/samples/[name].min.js
No conflicting references were found elsewhere. Please confirm that this directory layout aligns with your package distribution and build-pipeline requirements.
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (4)
package.json (1)
49-49: Left-over double space is a tiny nitThere are two consecutive spaces before
yarn workspace @webex/contact-center. Not harmful, just untidy.packages/@webex/contact-center/README.md (3)
19-21: Remove placeholder links or point them to real docsThe empty link targets (
[]()) trigger markdown-lint (MD042) and render as broken links on GitHub.-- [Introduction to the Webex Web Calling SDK]() -- [Quickstart guide]() +<!-- TODO: add real URLs once docs exist --> +<!-- - [Introduction to the Webex Web Calling SDK](<link-to-doc>) --> +<!-- - [Quick-start guide](<link-to-doc>) -->
55-60: Heading depth jumps and code-block language spec
# NPM/# CDNare H1s inside an H2 section (## Consuming SDK). Drop them one level and mark the bash blocks properly.-# NPM +### NPM … -# CDN +### CDN
75-77: Bare URL – wrap it in markdown link for accessibility-To test Contact Center SDK API, use this Kitchen Sink app: https://webex.github.io/webex-js-sdk/samples/contact-center/ +To test the Contact Center SDK API, visit the \ +[Kitchen Sink demo](https://webex.github.io/webex-js-sdk/samples/contact-center/).
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
docs/labs/contact-center/index.html(1 hunks)package.json(1 hunks)packages/@webex/contact-center/README.md(2 hunks)packages/@webex/contact-center/typedoc.json(1 hunks)packages/@webex/contact-center/typedoc.md(6 hunks)
✅ Files skipped from review due to trivial changes (3)
- packages/@webex/contact-center/typedoc.json
- packages/@webex/contact-center/typedoc.md
- docs/labs/contact-center/index.html
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: robstax
PR: webex/webex-js-sdk#3948
File: packages/@webex/webex-core/test/unit/spec/webex-core.js:178-254
Timestamp: 2024-11-01T00:30:53.442Z
Learning: In the webex-js-sdk project, when reviewing changes in `packages/@webex/webex-core/test/unit/spec/webex-core.js`, if the user declines to add negative test cases for invalid interceptor configurations, accept their decision and do not insist.
Learnt from: Kesari3008
PR: webex/webex-js-sdk#4258
File: packages/@webex/plugin-cc/src/webex.js:0-0
Timestamp: 2025-05-13T17:01:05.340Z
Learning: In the webex-js-sdk project, `PACKAGE_VERSION` is a constant that's injected by the build system and doesn't need to be explicitly imported in the source files.
Learnt from: pagour98
PR: webex/webex-js-sdk#4086
File: packages/@webex/plugin-cc/test/unit/spec/services/task/dialer.ts:52-57
Timestamp: 2025-02-12T10:13:06.265Z
Learning: In packages/@webex/plugin-cc tests, catch blocks in test cases follow CC Desktop pattern using `expect(true).toBe(true)` for consistency.
package.json (1)
Learnt from: Kesari3008
PR: #4258
File: packages/@webex/plugin-cc/src/webex.js:0-0
Timestamp: 2025-05-13T17:01:05.340Z
Learning: In the webex-js-sdk project, PACKAGE_VERSION is a constant that's injected by the build system and doesn't need to be explicitly imported in the source files.
packages/@webex/contact-center/README.md (5)
Learnt from: Kesari3008
PR: #4258
File: packages/@webex/plugin-cc/src/webex.js:0-0
Timestamp: 2025-05-13T17:01:05.340Z
Learning: In the webex-js-sdk project, PACKAGE_VERSION is a constant that's injected by the build system and doesn't need to be explicitly imported in the source files.
Learnt from: robstax
PR: #3948
File: packages/@webex/webex-core/test/unit/spec/webex-core.js:178-254
Timestamp: 2024-11-01T00:30:53.442Z
Learning: In the webex-js-sdk project, when reviewing changes in packages/@webex/webex-core/test/unit/spec/webex-core.js, if the user declines to add negative test cases for invalid interceptor configurations, accept their decision and do not insist.
Learnt from: pagour98
PR: #4086
File: packages/@webex/plugin-cc/test/unit/spec/services/task/dialer.ts:52-57
Timestamp: 2025-02-12T10:13:06.265Z
Learning: In packages/@webex/plugin-cc tests, catch blocks in test cases follow CC Desktop pattern using expect(true).toBe(true) for consistency.
Learnt from: bhabalan
PR: #4022
File: docs/samples/contact-center/app.js:116-118
Timestamp: 2024-12-06T12:48:03.643Z
Learning: In docs/samples/contact-center/app.js, hardcoding the OAuth client ID and secret is acceptable for testing purposes in an isolated sandbox environment.
Learnt from: pagour98
PR: #4086
File: docs/samples/contact-center/index.html:226-237
Timestamp: 2025-02-12T10:21:39.427Z
Learning: Accessibility improvements are not required for sample applications in the webex-js-sdk repository, as these apps primarily focus on demonstrating core functionality.
🪛 markdownlint-cli2 (0.17.2)
packages/@webex/contact-center/README.md
19-19: No empty links
(MD042, no-empty-links)
20-20: No empty links
(MD042, no-empty-links)
79-79: Heading levels should only increment by one level at a time
Expected: h2; Actual: h3
(MD001, heading-increment)
81-81: Bare URL used
(MD034, no-bare-urls)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Build Packages
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
3 participants
COMPLETES #< CAI-6612 >
This pull request addresses
Renames
@webex/plugin-ccto@webex/contact-centerand fix webpack config for cdn bundleby making the following changes
Change Type
The following scenarios were tested
Tested all the flows for all types of station login and outdial call.
The GAI Coding Policy And Copyright Annotation Best Practices
I certified that
Make sure to have followed the contributing guidelines before submitting.