Skip to content
This repository was archived by the owner on Dec 5, 2019. It is now read-only.

Conversation

@torvitas
Copy link

@torvitas torvitas commented Jul 7, 2017

Adds postinstall script, moves build tools from devDependencies to dependencies to build on install, adds src to files because npm removes most stuff that isnt listed there.

This fixes #70

…pendencies to build on install, adds src to

files because npm removes most stuff that isnt listed there
@jsf-clabot
Copy link

jsf-clabot commented Jul 7, 2017

CLA assistant check
All committers have signed the CLA.

@torvitas
Copy link
Author

torvitas commented Jul 7, 2017

Could someone please review the appveyor tests?

@alexander-akait
Copy link
Member

@torvitas we use webpack-defaults base repo for all webpack-contrib repos, PR is invalid, why your need src directory?

@torvitas
Copy link
Author

torvitas commented Jul 7, 2017

As described in the linked issue, because you added ./dist to gitignore we need to build it on installation. If you do not add src and also remove dist, there is nothing left ;)

Where do you want me to PR?

@alexander-akait
Copy link
Member

@torvitas npm don't use .gitignore for ignoring files, npm use .npmignore

@torvitas
Copy link
Author

torvitas commented Jul 7, 2017

You do not have ./dist in the repository at all.

@alexander-akait
Copy link
Member

@torvitas why we need dist in repo? Code in dist generate automatically before publish in npm

@torvitas
Copy link
Author

torvitas commented Jul 7, 2017

You didn't publish the beta tags yet. The way the package is right now it is not possible to install.

Try to npm install git+https://github.com/webpack-contrib/uglifyjs-webpack-plugin.git#master there will be an almost empty folder in node_modules/uglify-webpack-plugin

@alexander-akait
Copy link
Member

@torvitas don't need PR, just wait when some bug will be fixed and release will be publish

@torvitas
Copy link
Author

torvitas commented Jul 7, 2017

Well .. there is no sense in having an not installable beta. But I also got there is no willingness to accept my PR at all. You didn't even try to understand the problem I am trying to solve here.

Over and out.

@torvitas torvitas closed this Jul 7, 2017
@alexander-akait
Copy link
Member

@torvitas i understand your problems, there is not publish release because current master can contain bug (or unexpected behavior).

@torvitas
Copy link
Author

torvitas commented Jul 7, 2017

#70 (comment) completely solved it

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

all folders missing from package on npm install

4 participants