-
-
Notifications
You must be signed in to change notification settings - Fork 177
fixes #70 #71
fixes #70 #71
Conversation
…pendencies to build on install, adds src to files because npm removes most stuff that isnt listed there
|
Could someone please review the appveyor tests? |
|
@torvitas we use |
|
As described in the linked issue, because you added ./dist to gitignore we need to build it on installation. If you do not add src and also remove dist, there is nothing left ;) Where do you want me to PR? |
|
@torvitas npm don't use |
|
You do not have ./dist in the repository at all. |
|
@torvitas why we need |
|
You didn't publish the beta tags yet. The way the package is right now it is not possible to install. Try to npm install git+https://github.com/webpack-contrib/uglifyjs-webpack-plugin.git#master there will be an almost empty folder in node_modules/uglify-webpack-plugin |
|
@torvitas don't need PR, just wait when some bug will be fixed and release will be publish |
|
Well .. there is no sense in having an not installable beta. But I also got there is no willingness to accept my PR at all. You didn't even try to understand the problem I am trying to solve here. Over and out. |
|
@torvitas i understand your problems, there is not publish release because current master can contain bug (or unexpected behavior). |
|
#70 (comment) completely solved it |
Adds postinstall script, moves build tools from devDependencies to dependencies to build on install, adds src to files because npm removes most stuff that isnt listed there.
This fixes #70