docs(readme): update extract CSS example #731
Conversation
|
|
README.md
Outdated
| ### Extract | ||
|
|
||
| For production builds it's recommended to extract the CSS from your bundle being able to use parallel loading of CSS/JS resources later on. This can be achieved by using the [extract-text-webpack-plugin](https://github.com/webpack-contrib/extract-text-webpack-plugin) to extract the CSS when running in production mode. | ||
| For production builds it's recommended to extract the CSS from your bundle being able to use parallel loading of CSS/JS resources later on. This can be achieved by using the [extract-text-webpack-plugin](https://github.com/webpack-contrib/extract-text-webpack-plugin) for webpack version to extract the CSS when running in production mode. |
There was a problem hiding this comment.
Need rewrite this text to using mini-css-extract-plugin and remove mini-css-extract-plugin information from :warning
|
Also please accept CLA |
Codecov Report
@@ Coverage Diff @@
## master #731 +/- ##
=======================================
Coverage 98.43% 98.43%
=======================================
Files 11 11
Lines 384 384
Branches 90 90
=======================================
Hits 378 378
Misses 6 6Continue to review full report at Codecov.
|
|
@evilebottnawi review fixed, CLA accepted. |
README.md
Outdated
|
|
||
| For production builds it's recommended to extract the CSS from your bundle being able to use parallel loading of CSS/JS resources later on. This can be achieved by using the [extract-text-webpack-plugin](https://github.com/webpack-contrib/extract-text-webpack-plugin) for webpack version to extract the CSS when running in production mode. | ||
|
|
||
| > :warning: Since `webpack >= 4.0.0` the `extract-text-webpack-plugin` should not be used for css. Use [mini-css-extract-plugin](https://github.com/webpack-contrib/mini-css-extract-plugin) instead. |
There was a problem hiding this comment.
Return warning, many people still use ETWP for css, thanks for PR!
|
@evilebottnawi may I set to warning information about ETWP? And let example about mini-css as is? |
|
@DenRedsky yep, only warning about ETWP for webpack@4 |
|
Will fix it soon |
|
@evilebottnawi done, hope it's ok :) |
michael-ciniawsky
changed the title
|
@DenRedsky Please rebase your PR against latest |
|
Done in master, thanks for the PR |
4 participants
Update readme for webpack v4+.
What kind of change does this PR introduce?
Readme fix.
Did you add tests for your changes?
Nope.
If relevant, did you update the README?
Exactly.
Summary
Clarify information for current webpack version.
Does this PR introduce a breaking change?
Nope.
Other information