Unclear docs on default behavior for source maps

[koggdal]

Documentation Is:

• Missing
• Needed
• Confusing
• Not Sure?

Please Explain in Detail...

The release notes for 2.0.0 lists breaking changes (awesome!), but forgot to mention the change for source maps. The logic now looks for undefined for the sourceMap option and falls back to looking at devtool from the webpack config, which means the default behavior changed from false to possibly true depending on what devtool was set to.

Your Proposal for Changes

Could this be added to the breaking changes in the release notes for 2.0.0 to help the next person upgrading to ^2? :)

Maybe the above also needs to be clarified in the main docs. It's currently documented as Type: Boolean Default: false. How about adding the context around devtool in that line with Default: , or adding a reference like Default: false (see below for details)?

Thanks!

[alexander-akait]

Already in docs https://github.com/webpack-contrib/terser-webpack-plugin#sourcemap

The plugin respect the devtool. Using supported devtool values enable source map generation.

[alexander-akait]

But yes, feel free to send a PR with Default: false (see below for details)

[koggdal]

@evilebottnawi Okay, here you go! :) #151 How about the release notes change? I don't have access to update that!

[alexander-akait]

Done

[koggdal]

@evilebottnawi Thanks! But I still don't see the release notes updated with this listed under breaking changes?

[koggdal]

I didn't realize before that this project made use of both the CHANGELOG file and the GitHub releases page. Added a change to the file: #155 If you agree with that one, could you copy that over to the releases page too? :)