Set SourceMap Value based on Webpack Config #95
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Basically when switching over to use
terser-webpack-pluginI wasted some time trying to figure out why sourcemaps weren't working when I had configured it in the plugins for webpack, only to realize I needed to passsourceMap: trueto our TerserPlugin.I saw that the webpack defaults actually already do this, and it seems to make sense to do it here as well and remove the config.
#71
Breaking Changes
With this change, the default for
sourceMapdefers to the webpack configurationdevtoolor plugins that use theSourceMapDevToolPluginto define sourcemaps instead of defaulting tofalse.Additional Info