-
-
Notifications
You must be signed in to change notification settings - Fork 640
fix: graceful shutdown on watch/cache #4546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4546 +/- ##
==========================================
+ Coverage 89.68% 89.70% +0.02%
==========================================
Files 9 9
Lines 1396 1399 +3
Branches 445 447 +2
==========================================
+ Hits 1252 1255 +3
Misses 144 144
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should include this in the next major release, not now, and please add a test case
Still wip, need to send a sigterm signal whenever. |
14d14cd
to
4167dc8
Compare
4167dc8
to
f29d6e8
Compare
]); | ||
proc.stdout.on("data", (chunk) => { | ||
const data = chunk.toString(); | ||
if (data.includes("app.bundle.js")) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after compile is done and we got an async plugin the sigterm is invoked while we're in the child process without an infinite loop fyi @alexander-akait
mode: "development", | ||
name: "graceful-exit-test", | ||
cache: { | ||
type: "filesystem", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might need to specify cache.type
in the check at isFileSystemCacheEnabled
What kind of change does this PR introduce?
#3075
Did you add tests for your changes?
TBD
If relevant, did you update the documentation?
TBD
Summary
Does this PR introduce a breaking change?
No
Other information
Need to add tests.