Skip to content

Conversation

evenstensberg
Copy link
Member

What kind of change does this PR introduce?

#3075

Did you add tests for your changes?
TBD

If relevant, did you update the documentation?
TBD
Summary

Does this PR introduce a breaking change?

No

Other information

Need to add tests.

@evenstensberg evenstensberg requested a review from a team as a code owner September 16, 2025 13:04
Copy link

codecov bot commented Sep 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.70%. Comparing base (f407b24) to head (f29d6e8).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4546      +/-   ##
==========================================
+ Coverage   89.68%   89.70%   +0.02%     
==========================================
  Files           9        9              
  Lines        1396     1399       +3     
  Branches      445      447       +2     
==========================================
+ Hits         1252     1255       +3     
  Misses        144      144              
Files with missing lines Coverage Δ
packages/webpack-cli/src/webpack-cli.ts 90.70% <100.00%> (+0.02%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f407b24...f29d6e8. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should include this in the next major release, not now, and please add a test case

@evenstensberg
Copy link
Member Author

Still wip, need to send a sigterm signal whenever.

]);
proc.stdout.on("data", (chunk) => {
const data = chunk.toString();
if (data.includes("app.bundle.js")) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after compile is done and we got an async plugin the sigterm is invoked while we're in the child process without an infinite loop fyi @alexander-akait

@evenstensberg evenstensberg changed the title fix: gracefull shutdown on watch/cache fix: graceful shutdown on watch/cache Oct 4, 2025
mode: "development",
name: "graceful-exit-test",
cache: {
type: "filesystem",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might need to specify cache.type in the check at isFileSystemCacheEnabled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants