refactor: union sockHost, sockPath and sockPort in clientSocketOptions #2262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because opn was renamed to open.
* feat(server): add stdin for api * test(stdin): switch to async await tests for stdin * test(cli): use await timer
* feat(server): made user callback async, remove cli listen redundancy * test(server): added server listen method async callback tests * test(server): create options object using spread operator * chore(server): fix comment spelling
Codecov Report
@@ Coverage Diff @@
## next #2262 +/- ##
==========================================
+ Coverage 93.88% 93.96% +0.08%
==========================================
Files 34 36 +2
Lines 1276 1310 +34
Branches 363 372 +9
==========================================
+ Hits 1198 1231 +33
+ Misses 71 70 -1
- Partials 7 9 +2
Continue to review full report at Codecov.
|
hiroppy
force-pushed
the
next
branch
3 times, most recently
from
c54ae99 to
edfcfd6
Compare
hiroppy
force-pushed
the
next
branch
2 times, most recently
from
4408469 to
dc1c72f
Compare
alexander-akait
force-pushed
the
next
branch
2 times, most recently
from
d14892a to
5f1ad3b
Compare
Member
|
Done for v4, sorry for delay with this PR, anyway big thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Yes
Motivation / Use-Case
It's in the To Do list, Alternative to: #2047
Breaking Changes
sockHost, sockPath and sockPort options will be invalid.
Additional Info