refactor: the hot option
#2409
Merged
refactor: the hot option
#2409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: the `hotOnly` option was remove, please use `hot: "only"` instead
Codecov Report
@@ Coverage Diff @@
## next #2409 +/- ##
==========================================
- Coverage 91.99% 91.98% -0.02%
==========================================
Files 36 36
Lines 1324 1322 -2
Branches 373 372 -1
==========================================
- Hits 1218 1216 -2
Misses 97 97
Partials 9 9
Continue to review full report at Codecov.
|
| }); | ||
|
|
||
| it("should prepends webpack's hot-only client script", () => { | ||
| it("should prepends webpack's hot only client script", () => { |
Member
There was a problem hiding this comment.
Suggested change
| it("should prepends webpack's hot only client script", () => { | |
| it("should prepend webpack's hot only client script", () => { |
Member
Author
There was a problem hiding this comment.
I found a lot of mistakes in test names, let's open issue about it and fix all of them in a separate PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
using existing
Motivation / Use-Case
Simplify configuration
Breaking Changes
Yes
Additional Info
No