Skip to content

Conversation

@papandreou
Copy link
Contributor

Fix unencoded star character in img src url (https://img.shields.io/github/stars/webpack/memory-fs.svg?label=✭&style=flat-square&maxAge=3600)

Caused npm run linkcheck to break.

This is a hopefully nicer alternative to disabling the link check: #2759

We'll look into making hyperlink either tolerate this kind of invalid url (if browsers tolerate it), or throw a specific error message instead of an internal error.

@Munter
Copy link
Collaborator

Munter commented Jan 15, 2019

When the tests could run without throwing, another problem showed itself: webpack-contrib/cache-loader#60

I'll merge this one though, because it clearly fixes a problem, and the broken link that was introduced is a part of an external repository

@Munter Munter merged commit 5f8175a into webpack:rebuild Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants