Skip to content

Conversation

@barbeque
Copy link

I didn't quite understand that this had to be a type="file" input element and I had to read the filedrop source code to figure it out.

If this is helpful, I could also create a pull request to throw an error on filedrop initialization if the fallback element is not of type file.

@barbeque
Copy link
Author

I've gone ahead and made the following changes that I mentioned in the original post:

  • Errors will no longer be raised when the fallback_id is unset
  • If the fallback_id is set and the target element is not an input[type=file], it will raise an error: Fallback element [upload_button] must be of type 'file', but it is of 'button'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant