Drop async_trait #209
Merged
Drop async_trait #209
+186
−140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit remove `#[async_trait::async_trait]` wherever possible It mainly replaces it with the "new" `-> impl Future` support in traits. There are still a few places that need to continue to use `BoxFuture` instead due to bugs in rustc.
weiznich
force-pushed
the
drop_async_trait
branch
from
efff429 to
6250cee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit remove
#[async_trait::async_trait]wherever possibleIt mainly replaces it with the "new"
-> impl Futuresupport in traits. There are still a few places that need to continue to useBoxFutureinstead due to bugs in rustc.