Skip to content

Conversation

philsturgeon
Copy link
Contributor

@philsturgeon philsturgeon commented Apr 9, 2018

Contains #2 also.

By adding more examples I'm able to find more keywords and discrepancies. This one particularly helped find an issue.

  1. The root level id should be remove just like $schema is already.
  2. dependencies will be switched to OpenAPI equivalent (thanks @handrews)

@philsturgeon philsturgeon changed the title Remove $id and id from the root as well as $schema Remove id from the root Apr 9, 2018
@philsturgeon philsturgeon changed the title Remove id from the root Support "advanced example" from JSON Schema Apr 9, 2018
@handrews
Copy link

handrews commented Apr 9, 2018

dependencies stuff looks good. Skimmed the rest, looks fine but did not go into detail on all of the example files.

How are you handling it when id affected how $ref resolved? Just removing id can leave that broken.

@philsturgeon philsturgeon merged commit 8e72209 into master Apr 9, 2018
@philsturgeon philsturgeon deleted the examples branch April 9, 2018 21:04
@philsturgeon
Copy link
Contributor Author

I'll put that on the TODO @handrews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants