Editorial: align with Infra #348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make several improvements: - Stop using "then" before nested steps. - Start using "then" after an if conditional. - Use camel case for variables (codeUnit, not code unit). - Stop manipulating state and initializing variables in a conditional for nested steps. (More needs to be done, but this also needs to be reviewable.)
|
I did a drive-by review and LGTM, if that's useful. I was mostly curious about the "Stop using "then" before nested steps." change, as for WebNN we'd settled on the opposite (i.e. always pairing "if" with "then"). Nice to see conventions emerge! |
domenic
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make several improvements:
(More needs to be done, but this also needs to be reviewable.)
Preview | Diff