structuredClone() should use StructuredDeserializeWithTransfer
#7081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`StructuredDeserialize` expects the first argument to be a record containing the [[Type]] slot, as would be returned by `StructuredSerialize` and `StructuredSerializeForStorage`. `StructuredSerializeWithTransfer` returns instead a record with [[Serialized]] and [[TransferDataHolders]] slots, which must be deserialized using the `StructuredDeserializeWithTransfer` operation. It seems like this was an oversight in whatwg#3414.
surma
approved these changes
Sep 17, 2021
Contributor
surma
left a comment
surma
left a comment
There was a problem hiding this comment.
It seems to me that you are correct! But gonna wait on one of the HTML folks to weigh in with authority on this one :) Thank you for fixing this!
domenic
approved these changes
Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StructuredDeserializeexpects the first argument to be a record containing the [[Type]] slot, as would be returned byStructuredSerializeandStructuredSerializeForStorage.StructuredSerializeWithTransferreturns instead a record with [[Serialized]] and [[TransferDataHolders]] slots, which must be deserialized using theStructuredDeserializeWithTransferoperation.It seems like this was an oversight in #3414.
cc @surma
structuredClone()should do:(See WHATWG Working Mode: Changes for more details.)
/structured-data.html ( diff )