Make it explicit that user agents can ignore replaceState/pushState #999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
source
Outdated
| listeners that are not triggered in response to a clear user action, or that are invoked in rapid | ||
| succession.</p> | ||
| <p>For both <code data-x="dom-history-pushState">pushState()</code> and <code | ||
| data-x="dom-history-replaceState">replaceState()</code>, user agents should be careful to prevent |
Member
There was a problem hiding this comment.
Since this appears in a non-normative section, we cannot use should.
|
Lgtm, except for what @annevk already noted. |
It should be next to the other session history stuff.
Fixes #982. The "a user agent could ignore calls" is moved from the non-normative implementation notes to the normative algorithm, and the implementation notes are updated with a pointer to this.
domenic
force-pushed
the
warn-replacestate
branch
from
e5cbe66 to
38139b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #982. The "a user agent could ignore calls" is moved from the
non-normative implementation notes to the normative algorithm, and the
implementation notes are updated with a pointer to this.
@beidson, can you review?