Skip to content

Fix button shape #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix button shape #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
af2af57
add new button use-case
GiancarloMennillo Feb 26, 2025
3ffb571
fix button radius
GiancarloMennillo Feb 26, 2025
b64dbe8
revert change
GiancarloMennillo Feb 26, 2025
7a11955
change shape
GiancarloMennillo Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/ui/widgets/primary_button.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ class PrimaryButton extends StatelessWidget {
? AppTheme.of(context).background.primaryInactive
: AppTheme.of(context).background.brand,
borderRadius: BorderRadius.circular(
AppTheme.of(context).radius.none,
AppTheme.of(context).radius.full,
),
),
child: Row(
Expand Down
14 changes: 14 additions & 0 deletions widgetbook/lib/ui/widgets/primary_button.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,19 @@ import 'package:groceries_app/ui/ui.dart';
import 'package:widgetbook/widgetbook.dart';
import 'package:widgetbook_annotation/widgetbook_annotation.dart';

@UseCase(
name: 'Default',
type: PrimaryButton
)
Widget buildPrimaryButton(BuildContext context) {
return PrimaryButton(content:
context.knobs.string(
label: 'Content',
initialValue: 'Button',
),

);
}

// TODO: Implement the PrimaryButton use-case
// DESIGN: https://www.figma.com/design/HsANkdhbsCNTkXBzNJRNLD/Groceries-Demo?node-id=7235-4663&t=N6qwmLP7MP59ClWB-4
2 changes: 1 addition & 1 deletion widgetbook/macos/Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,4 @@ SPEC CHECKSUMS:

PODFILE CHECKSUM: 236401fc2c932af29a9fcf0e97baeeb2d750d367

COCOAPODS: 1.15.2
COCOAPODS: 1.16.2