Set description when converting MappingModel to IRespondWithAProvider #1317
+11
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a mapping with a description to `WireMockServer.WithMapping` did not include the description to the resulting `IRespondWithAProvider`, which means that calling `WireMockServer.SavePact` does not populate the description in the contract file. This PR includes the description when mapping from `MappingModel` to `IRespondWithAProvider`.
chrisbillson
approved these changes
Jun 12, 2025
StefH
approved these changes
Jun 12, 2025
This was referenced Jul 23, 2025
This was referenced Jul 31, 2025
This was referenced Aug 11, 2025
This was referenced Aug 19, 2025
This was referenced Aug 26, 2025
This was referenced Sep 26, 2025
This was referenced Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a mapping with a description to
WireMockServer.WithMappingdid not include the description to the resultingIRespondWithAProvider, which means that callingWireMockServer.SavePactdoes not populate the description in the contract file.This PR includes the description when mapping from
MappingModeltoIRespondWithAProvider.Submitter checklist
#help-contributingor a project-specific channel like#wiremock-java