Feature/optional lowercase #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MRudolph |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request extends the command line tool for training and evaluation (iitb.Segment.Segment) by making downcasing of tokens optional.
This seems to be a destructive action, because it's done before the features are generated.
Some languages (e.g. german) depend on capitalisation for distinguishing words, so this might be a valuable resource which should not removed.
For not breaking existing setups, there are new methods which can handle the optional downcasing.
It's on by default, but can switched off by adding "lowercase=false" to the configuration.
Tests are included and succeed (they are modified copies of the tests for the original tests).
Running the applications with the sample dataset also seems to work fine.