This repository was archived by the owner on Oct 11, 2022. It is now read-only.
codeblock language switch #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah! We use [email protected] |
Author
|
|
|
Nice!! 😍 |
Author
|
juliankrispel
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I believe we want this - a language switcher for code blocks
draft-js editors often use click events (to focus on the editor or whatever) so I'd use react-portal to display the language selection menu.
Are there any components that you guys already use or that you prefer using? It's just that there are hundreds of components like these - so any pointers as to how you'd like to have it implemented would be cool.
cc @mxstbr