Skip to content
This repository was archived by the owner on Oct 11, 2022. It is now read-only.

Handle multiple simultaneous markdown transformations #44

Merged
merged 1 commit into from
Apr 6, 2018
Merged

Handle multiple simultaneous markdown transformations #44

merged 1 commit into from
Apr 6, 2018

Conversation

@juliankrispel
Copy link

@juliankrispel juliankrispel commented Apr 6, 2018

  • refactor inline style handlers to keep looking for markdown delimiters until no matches are found
  • add test case for multiple simultaneous markdown transforms
  • handles multiple markdown delimiters while still restricted to ones that border on the selection focus

fixes #40

fix-matchers

@juliankrispel juliankrispel requested a review from mxstbr April 6, 2018 08:25
@juliankrispel juliankrispel mentioned this pull request Apr 6, 2018
Closed
mxstbr
mxstbr approved these changes Apr 6, 2018
View reviewed changes
Copy link

@mxstbr mxstbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're the best! 💯

@mxstbr mxstbr merged commit 7002ed8 into master Apr 6, 2018
@mxstbr mxstbr deleted the fix-inline-matcher branch April 6, 2018 08:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mxstbr mxstbr mxstbr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Mixed inline styles bugs in 1.3.0

3 participants

@juliankrispel @mxstbr