Fix stub generation for imported methods #1055
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
|
Could you please add a test that covers this new feature? You will also need to update the stub reference files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, stub generation mishandles the case where a method is actually a function imported from a different module. (It simply imports the name as the name of the method and calls it a day. A name never gets added to the class namespace.)
This can arise, for example, if one adds methods to nanobind-generated classes via monkeypatching.
Full disclosure: this is a bit of a drive-by PR. I did not investigate if/how type stubs are tested. If you'd like me to add testing or make other revisions, I would be happy to.