Skip to content

Support verifying messages with multiple signers #8844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

komelchenko-vcc
Copy link

@komelchenko-vcc komelchenko-vcc commented Jun 5, 2025

Description

Support verifying messages with multiple signers. (ZD 20046)

Testing

Verifying by make unit_test. The output can be found in wolfssl-unit_test-out.txt, if required.

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@wolfSSL-Bot
Copy link

Can one of the admins verify this patch?

@dgarske
Copy link
Contributor

dgarske commented Jun 5, 2025

Hi @komelchenko-vcc ,

Thank you for this excellent contribution. I don't see you setup as a contributor yet. Please send an email to support at wolfssl dot com and reference this PR to get that process started.

Thanks,
David Garske, wolfSSL

@JacobBarthelmeh
Copy link
Contributor

Ok to test

Preimptevily letting Jenkins run tests on the changes. Thanks for the opening the pull request and submiting the code! If you have not yet, please contact [email protected] to start that process.

@dgarske
Copy link
Contributor

dgarske commented Jun 11, 2025

Retest this please: "history lost"

Copy link
Contributor

@dgarske dgarske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still waiting on contributor agreement. @JacobBarthelmeh please review when you have time as you are very familiar with the PKCS7 code.

@dgarske
Copy link
Contributor

dgarske commented Jun 20, 2025

Retest this please

@dgarske dgarske requested a review from JacobBarthelmeh June 26, 2025 14:13
@dgarske
Copy link
Contributor

dgarske commented Jun 26, 2025

Jenkins retest this please. Correct issue with FIPSv5 typo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants