Skip to content

Switches to cross-spawn to fix issues with Windows shells #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 25, 2017
Merged

Switches to cross-spawn to fix issues with Windows shells #50

merged 2 commits into from
Nov 25, 2017

Conversation

claudiopro
Copy link
Member

@claudiopro claudiopro commented Feb 28, 2017 •
edited
Loading

Fixes #43, switches to cross-spawn which addresses these issues:

  • child_process.spawn unable to execute .cmd or .bat commands on Windows
  • shell: true working only with Node >=v6 (according to cross-spawn; Node docs say it's supported since v4)
  • Caller has to escape command and arguments when using shell: true

@claudiopro claudiopro added the bug label Feb 28, 2017
@claudiopro
Copy link
Member Author

Actually it was cherry-picked into v4 LTS and v5 too, see nodejs/node#4598. I'll open a PR to clarify this in cross-spawn.

@claudiopro claudiopro requested review from martinheidegger and removed request for sethvincent February 28, 2017 18:35
@claudiopro claudiopro merged commit 54fab8b into workshopper:master Nov 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martinheidegger martinheidegger Awaiting requested review from martinheidegger

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@claudiopro