feat: add response header propagation #1155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StarpTech
requested changes
Sep 9, 2024
Contributor
There was a problem hiding this comment.
Quick feedback on the existing functionality: The cache header implementation needs an extensive testsuite. I suggest to split header propagation and cache header handling in two distinct core modules and different configuration. This would improve maintainability and increase awareness of the features. Caching is a complex topic and I expect more customizability in the future here (minTTL, default etc...). A dedicated config section would be great here and allow us to add more in the future.
http_cache:
enabled: true
defaultTTL: 30m
minTTL: 5m
|
@jensneuse We have the requirement to propagate response header at RCCL ( Royal Caribbean ). We really appreciate the fix coming in. Please let me know timeline on this, so that we can plan accordingly. |
df-wg
force-pushed
the
jens/eng-5420-support-cache-control-headers-from-subgraph-responses
branch
3 times, most recently
from
5a41636 to
7ad9645
Compare
StarpTech
requested changes
Sep 16, 2024
jensneuse
commented
Sep 18, 2024
… default value that will be applied
df-wg
force-pushed
the
jens/eng-5420-support-cache-control-headers-from-subgraph-responses
branch
from
7ad9645 to
a847111
Compare
jensneuse
deleted the
jens/eng-5420-support-cache-control-headers-from-subgraph-responses
branch
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.