CA-142451: Unit tests #212
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
test this please |
|
This pull request must be applied first so that the unit tests work: Thanks, |
tests/test_ISCSISR.py
Outdated
There was a problem hiding this comment.
Maybe create an assertDevicePath method:
...
self.assertPath(self.node1, iscsi_sr.path)
self.assertEquals(node1_ip_port, iscsi_sr.tgtidx)
self.assertEquals(node1_ip_port, iscsi_sr.address)
...After that these 3 could be moved to one assertion:
self.assertActiveNode(node1, iscsi_sr)Covering changes related to CA-142451. Signed-off-by: Flavien Quesnel <[email protected]>
fquesnel
force-pushed
the
unittestxs64bit
branch
from
7d7739f to
52762be
Compare
|
test this please |
|
why do we have unit tests for something that is not in xs64bit? The original PR is for master only. Then everything will be backported altogether in xs64bit. Am I wrong? |
|
retest this please |
|
Closing it down, as #213 covers this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Covering changes related to CA-142451.
Signed-off-by: Flavien Quesnel [email protected]