Simplify clocks API #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- High-level API for generating clock coordinate data is not supported anymore - auto_adjust clock coordinate labels has been removed (an error is raised instead) - It is possible to use update_clocks to update only some clock coordinates (all clock coordinates are not dropped first anymore)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #35.
start,end,steparguments) is not supported anymore. This could be added back in a future release in a different, cleaner form. The new API is more consistent with how we set coordinates in xarray.auto_adjustclock coordinate labels has been removed (an error israised instead). A cleaner implementation should be added back in a future release (e.g., with options like
'nearest'but also'intersection'to simply exclude invalid labels).Dataset.xsimlab.update_clocksto update only some clockcoordinates (previously all clock coordinates were dropped first).