Skip to content

Conversation

@H31nz3l
Copy link
Collaborator

@H31nz3l H31nz3l commented Apr 2, 2025

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

[For example #12]

Description of Changes Made (if issue reference is not provided)

[Description goes here]

@H31nz3l H31nz3l merged commit 8889145 into xip-online-applications:merge-prep Apr 2, 2025
14 of 15 checks passed
@codecov
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

Attention: Patch coverage is 98.78049% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.93%. Comparing base (8c4566c) to head (7d890ff).
Report is 18 commits behind head on merge-prep.

Files with missing lines Patch % Lines
rust/cubesql/cubesql/src/compile/test/utils.rs 88.88% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           merge-prep      #68      +/-   ##
==============================================
+ Coverage       80.91%   80.93%   +0.01%     
==============================================
  Files             229      229              
  Lines           82614    82694      +80     
==============================================
+ Hits            66851    66931      +80     
  Misses          15763    15763              
Flag Coverage Δ
cubesql 80.93% <98.78%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants