Fix lost chunks during streaming of large volumes of data. #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current streaming implementation allows for chunks of data
to be lost in VSSH's default select{} cases, if volumes of data
arrive at a rate too high to be processed. The default cases
get selected when the write channel buffer becomes full and
would block. This patch puts a client into a streaming mode
when the GetStream() function is called, which causes a blocking
select{} to be used until the streaming mode is ended.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current streaming implementation allows for chunks of data to be lost in VSSH's default select{} cases, if volumes of data arrive at a rate too high to be processed. The default cases get selected when the write channel buffer becomes full and would block. This patch puts a client into a streaming mode when the GetStream() function is called, which causes a blocking select{} to be used until the streaming mode is ended.
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.