`yarn add --cwd invalid-dir` should warn/fail

[thatmarvin]

Do you want to request a feature or report a bug?

Bug

What is the current behavior?
yarn add --cwd invalid-dir bluebird installs bluebird to the root:

yarn add v1.3.2
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
[4/4] 📃  Building fresh packages...
success Saved lockfile.
success Saved 1 new dependency.
└─ bluebird@3.5.1
✨  Done in 0.30s.

If the current behavior is a bug, please provide the steps to reproduce.

Just yarn add --cwd invalid-dir bluebird (and invalid-dir not exist, of course)

What is the expected behavior?
Throw an error, or at least show a warning.

For reference, on npm 5.6.0, npm --prefix invalid-dir bluebird creates invalid-dir and installs it there (which I also think is unexpected behavior), but at least it throws a warning:

$ npm i --prefix invalid-dir bluebird
npm WARN saveError ENOENT: no such file or directory, open '/Users/marvin/devel/yarn-add-cwd-demo/invalid-dir/package.json'
npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN enoent ENOENT: no such file or directory, open '/Users/marvin/devel/yarn-add-cwd-demo/invalid-dir/package.json'
npm WARN invalid-dir No description
npm WARN invalid-dir No repository field.
npm WARN invalid-dir No README data
npm WARN invalid-dir No license field.

+ bluebird@3.5.1
added 1 package in 0.734s

Please mention your node.js, yarn and operating system version.
node v8.9.4, yarn 1.3.4, macOS High Sierra 10.13.2

[maciej-ka]

Hi, I'm on it.

[witalewski]

Is this issue solved? If not, I'd like to tackle this

[arcanis]

It should have been fixed in #5222 (1.5+). Still having this issue?

[witalewski]

I'm still having it with yarn 1.13 if the path passed to --cwd doesn't begin with '/':

yarn on  master [!?] is 📦 v1.13.0-0 via ⬢ v8.11.4 took 2s
➜ node $PWD/lib/cli/index.js add --cwd /nonexistent bluebird
yarn add v1.13.0-0
error Directory "/nonexistent" doesn't exist
info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.

yarn on  master [!?] is 📦 v1.13.0-0 via ⬢ v8.11.4
➜ node $PWD/lib/cli/index.js add --cwd nonexistent bluebird
yarn add v1.13.0-0
[1/5] 🔍  Validating package.json...
[2/5] 🔍  Resolving packages...
[3/5] 🚚  Fetching packages...
[4/5] 🔗  Linking dependencies...
warning " > eslint-config-fb-strict@22.4.3" has incorrect peer dependency "eslint-plugin-babel@^4.1.1".
warning "eslint-config-fb-strict > eslint-config-fbjs@2.0.1" has incorrect peer dependency "eslint-plugin-babel@^4.1.1".
[5/5] 📃  Building fresh packages...
success Saved 1 new dependency.
info Direct dependencies
└─ bluebird@3.5.2
info All dependencies
└─ bluebird@3.5.2
✨  Done in 10.65s.

[mollyIV]

👋 I was testing the fix for yarn v1.16.0.

Directory path starting with / 👍

$ yarn add --cwd /invalid-dir bluebird
yarn add v1.16.0
error Directory "/invalid-dir" doesn't exist
info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.

Directory path not starting with / (I can imagine that might be a case of relative path or the path on Windows) 🐛

$ yarn add --cwd invalid-dir bluebird
yarn add v1.16.0
info No lockfile found.
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
[4/4] 🔨  Building fresh packages...

success Saved lockfile.
success Saved 1 new dependency.
info Direct dependencies
└─ bluebird@3.5.5
info All dependencies
└─ bluebird@3.5.5
✨  Done in 0.39s.

If you do not mind, I would like to work on this and create a PR with the fix 🙏🙇