Skip to content

Conversation

@BYK
Copy link
Member

@BYK BYK commented Apr 26, 2018

Summary

Thanks for all the fish Node 4, you won't be missed. Fixes #5872.

Test plan

CI builds should pass.

Thanks for all the fish Node 4, you won't be missed.
@BYK BYK requested review from Daniel15, arcanis and bestander April 26, 2018 09:21

PACKAGE_TMPDIR=tmp/debian_pkg
VERSION=`./artifacts/yarn-legacy-* --version`
VERSION=`./artifacts/yarn-* --version`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work because ./artifacts/yarn-......tar.gz also matches this glob:

+ PACKAGE_TMPDIR=tmp/debian_pkg
++ ./artifacts/yarn-1.6.0.js ./artifacts/yarn-v1.6.0.tar.gz --version
 
error Command "./artifacts/yarn-v1.6.0.tar.gz" not found.

(https://circleci.com/gh/yarnpkg/yarn/14701?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Will see what we can do about it.

@arcanis
Copy link
Member

arcanis commented Apr 26, 2018

Approve but this is a major change, right? We probably should wait until we want to release a v2 before merging it.

@buildsize
Copy link

buildsize bot commented Apr 26, 2018

File name Previous Size New Size Change
yarn-[version].noarch.rpm 917.44 KB 891.63 KB -25.81 KB (3%)
yarn-[version].js 3.97 MB 3.97 MB -24 bytes (0%)
yarn-legacy-[version].js 4.13 MB [deleted]
yarn-v[version].tar.gz 922.51 KB 896.86 KB -25.65 KB (3%)
yarn_[version]all.deb 681.28 KB 664.76 KB -16.51 KB (2%)

@BYK
Copy link
Member Author

BYK commented Apr 26, 2018

We probably should wait until we want to release a v2 before merging it.

Yeah, I was gonna ask about this. I think this deserves a major version bump :(

@arcanis arcanis mentioned this pull request May 2, 2018
5 tasks
@BYK
Copy link
Member Author

BYK commented Dec 1, 2020

Closing as I don't think we'll be releasing another major version of the legacy Yarn at all as Yarn v2 is going along quite well :)

@BYK BYK closed this Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop support for Node 4

5 participants