Fix generated .pnp.js compatibility with Node 6. #6871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 3, 2019 11:47
Prior to these changes the generated `.pnp.js` file would use trailing commas for function invocations which is not allowed (and generates a parse error) under Node 6. This removes the offending trailing commas...
This file does not get transpiled down for Node 4 compat like other files, so we cannot use `"trailingComma": "all"` configuration (the default prettier config for this repo).
rwjblue
force-pushed
the
fix-pnp-node-6-compat
branch
from
32c8a19 to
d6841b8
Compare
|
Thanks! Regarding the tests, the simplest would likely be to make the acceptance tests work on Node 6. It could be kept in a separate branch and be periodically updated with the new master. This way we wouldn't have to downgrade the codebase and would still benefit from an automated testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Prior to these changes the generated
.pnp.jsfile would use trailing commas for function invocations which is not allowed (and generates a parse error) under Node 6.Test plan
I would like to add some CI testing of the generated
.pnp.jsfiles to ensure that Node 4 and Node 6 continue to work (and do not regress) until the project officially drops support for them, but I am not quite sure how to go about it.