Adds test for #6968 #7000
Open
Adds test for #6968 #7000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 4, 2019 14:01
Fixes tests from yarnpkg#6413
clphillips
approved these changes
Feb 4, 2019
arcanis
reviewed
Feb 5, 2019
| headers: {Connection: 'close'}, | ||
| }, | ||
| resolve: body => {}, | ||
| reject: err => { |
There was a problem hiding this comment.
Shouldn't this callback be spied on? At the moment Jest doesn't check whether it's actually called 🤔
There was a problem hiding this comment.
I was actually just following existing convention, but it looks like the tests are invoking the callback manually, which runs the "async" resolution. The await in front of config.requestManager.execute is misleading because RequestManager#execute is a void method.
The tests technically test the correct behavior, but could probably be a bit more straightforward.
I have little knowledge on how tests work in yarn. GTM as long as tests pass :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#6968 fixed a regression where a class of errors from
requestwere unhandled (leaving ssl cert errors to be swallowed).This PR just adds a test to hopefully catch future regressions.
While adding this test, I noticed some tests from #6413 were leaking and addressed that as well.
@arcanis and @yan12125 do these changes look helpful?
I did not update
CHANGELOGas actual code was unchanged.Test plan
Successfully ran
yarn test