Skip to content

Conversation

@terabytesoftw
Copy link
Member

Q A
Is bugfix?
New feature? ✔️
Breaks BC?

@what-the-diff
Copy link

what-the-diff bot commented Oct 4, 2023

PR Summary

  • Updated Coding Style for YAML files
    The .editorconfig file was changed to standardize the indent size to 2 for all YAML files. This helps maintain a consistent code format across the codebase.

  • Updated PHP and PHPUnit Version Requirements
    The composer.json file was updated to require at least PHP version 7.3 and PHPUnit version 9.6. This ensures our code stays compatible with recent versions of these tools, benefiting from their latest features and improvements.

  • Improved Testing
    Several test files (AccordionTest.php, ActiveFieldDefaultFormCheckTest.php, ActiveFieldTest.php, ActiveFormTest.php, ButtonDropdownTest.php, CarouselTest.php, LinkPagerTest.php, ModalTest.php, NavBarTest.php, NavTest.php, OffcanvasTest.php, PopoverTest.php, TabsTest.php, ToastTest.php, ToggleButtonGroupTest.php, TestCase.php, TranslationTest.php) have been updated to use more accurate and expressive assertions in their tests. This enhances the precision of our unit tests and makes them easier to understand.

  • Enhanced Test Setup and Teardown
    Certain test files (TestCase.php, TranslationTest.php) now include return types for their setUp() and tearDown() methods. This enforces stronger type safety in our test suite.

  • Deprecated Method Removal
    Obsolete PHPUnit methods have been replaced throughout the codebase, ensuring we stay up-to-date with latest best practices in testing.

@codecov
Copy link

codecov bot commented Oct 4, 2023

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@simialbi
Copy link
Collaborator

fixed with #93

@simialbi simialbi closed this Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants