Skip to content

Conversation

@terabytesoftw
Copy link
Member

Q A
Is bugfix? ✔️
New feature?
Breaks BC?

@what-the-diff
Copy link

what-the-diff bot commented Aug 29, 2023

PR Summary

  • Modification of export function in FileTarget.php
    • The check for whether the text to be exported is empty or not has been changed. This provides more accurate results.
    • The variable used to save the text in the file has been updated. The original text variable is used instead of a trimmed version of the text. This ensures that the full text gets saved without any unintentional truncation.
    • The error messages for issues arising during the export process have been updated to be more descriptive, helping to troubleshoot problems more effectively.
    • The original text is now used to calculate the size of the text being exported. This accurately reflects the size of the data being handled.

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch coverage: 14.28% and project coverage change: -26.74% ⚠️

Comparison is base (4ffb58e) 48.95% compared to head (45c7bb0) 22.22%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #19941       +/-   ##
===========================================
- Coverage   48.95%   22.22%   -26.74%     
===========================================
  Files         445      445               
  Lines       42807    41998      -809     
===========================================
- Hits        20957     9334    -11623     
- Misses      21850    32664    +10814     
Files Changed Coverage Δ
framework/db/BaseActiveRecord.php 76.27% <ø> (-1.32%) ⬇️
framework/db/Migration.php 21.19% <ø> (+4.52%) ⬆️
framework/helpers/mimeExtensions.php 0.00% <0.00%> (-0.09%) ⬇️
framework/helpers/mimeTypes.php 0.00% <0.00%> (-0.31%) ⬇️
framework/log/FileTarget.php 0.00% <0.00%> (-63.10%) ⬇️
framework/BaseYii.php 71.66% <100.00%> (-16.67%) ⬇️

... and 234 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@terabytesoftw terabytesoftw linked an issue Aug 29, 2023 that may be closed by this pull request
@bizley
Copy link
Member

bizley commented Aug 30, 2023

Please add changelog line, cheers.

@terabytesoftw
Copy link
Member Author

Please add changelog line, cheers.

done.

@bizley bizley added the type:bug Bug label Aug 30, 2023
@bizley bizley added this to the 2.0.50 milestone Aug 30, 2023
@bizley bizley merged commit 671fbef into yiisoft:master Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

File Log writer without newline

2 participants