Drop support for Python2 and Django < 1.10 #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djm
reviewed
Feb 28, 2018
request_token/models.py
Outdated
| def _auth_is_anonymous(self, request): | ||
| """Authenticate anonymous requests.""" | ||
| assert request.user.is_anonymous(), 'User is authenticated.' | ||
| assert request.user.is_anonymous, 'User is authenticated.' |
There was a problem hiding this comment.
Ah, this is bad. assert can be stripped by the compiler so this code could effectively be a pass on those that do so. We don't run with compiler optimisations stripping the asserts, but as this is OS I feel we have a little duty to fix this up.
Can be replaced with a conditional instead, which never get stripped.
There was a problem hiding this comment.
True - but not part of this PR.
djm
reviewed
Feb 28, 2018
request_token/models.py
Outdated
| def _auth_is_authenticated(self, request): | ||
| """Authenticate requests with existing users.""" | ||
| assert request.user.is_authenticated(), 'User is anonymous.' | ||
| assert request.user.is_authenticated, 'User is anonymous.' |
|
@djm asserts removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides dual-support for Django 1.11 and 2.0, drops support for python2.
is_authenticated(), is_anonymous()to propertieson_deleteto all foreign keys, and update migrationsurls.pyto handle 1.11 and 2.0re_pathformatRequestTokenMiddlewareto drop use ofMiddlewareMixinin favour of new stylesix