chore: use common msrv for the workspace #2965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
may need to update a make target that was parsing this toml for the MSRV |
nsarlin-zama
force-pushed
the
ns/chore/workspace_msrv
branch
from
d15963d to
ac925f5
Compare
nsarlin-zama
commented
Oct 30, 2025
There was a problem hiding this comment.
Reviewable status: 0 of 8 files reviewed, 1 unresolved discussion (waiting on @IceTDrinker and @soonum)
tfhe/Cargo.toml line 20 at r1 (raw file):
Previously, IceTDrinker wrote…
may need to update a make target that was parsing this toml for the MSRV
good catch, fixed
Since cargo commands create a lock using the smallest msrv in the workspace, it can prevent getting up-to-date dependencies
nsarlin-zama
force-pushed
the
ns/chore/workspace_msrv
branch
from
ac925f5 to
5fdd95c
Compare
|
cargo audit works after this pr: https://github.com/zama-ai/tfhe-rs/actions/runs/18941093224 |
IceTDrinker
approved these changes
Oct 30, 2025
There was a problem hiding this comment.
Thanks a lot !
@IceTDrinker reviewed 7 of 7 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @soonum)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since cargo commands create a lock using the smallest msrv in the workspace, it can prevent getting up-to-date dependencies
closes: please link all relevant issues
PR content/description
Cargo commands will create a lockfile using the smallest msrv in the workspace.
This leads to a situation where crate A with a high msrv will be restrained to dependencies compatible with a low msrv because of an unrelated crate B in the workspace.
To simplify this, we set a common msrv for the workspace.
I did not update the version of zk-pok and versionable because they are already updated by #2950
This change is