fix: now extension's typing snippets are usable within live share sessions #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't even reproduce the issue - typing snippets work fine when I start live share and use the vscode's web version as the second participant. However I recall some issues when we used live share together and if you wan't me investigate and try to fix them, please, provide some steps to reproduce or smth as I don't understand what is going wrong rn :( |
|
Thanks but I already fixed it in this pr and didn’t mean you to fix it 🎉 you needed to have better snippets installed on both sides and have the same typing snippets. The problem was is that typing a typing snippet on guest side would also trigger it on the host side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mostly fixes #11 , but there is still a problem when both cursors (host and some guest) are on the same location at the file, but it is possible to workaround this problem as well with kind from
onDidChangeTextEditorSelectionwhich is command on other side change I think, but I wont focus on it for now