fix(tooltip): don't pass in a ref as it's not actually needed #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzempel
approved these changes
Aug 1, 2019
austingreendev
approved these changes
Aug 1, 2019
1 task
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Passing in the tooltip ref was completely pointless and made it hard to work with.
Detail
I believe I was trying to work around the bug fixed here rather than actually needing the ref to the tooltip for any useful reason.
Even though this removes a prop it's not actually a breaking change since you can still pass the ref and it'll work fine, it just doesn't use the ref passed.
I think this react PR merged in the latest react (beta/alpha?) might fix the underlying issue and not require the
isMounttracking.facebook/react#15650
Checklist
Storybook demo is up-to-date (yarn start)analyzed via axe and evaluated using VoiceOver