std.process.Child: fix double path normalization in spawnWindows #24562
+71
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squeek502
reviewed
Jul 24, 2025
squeek502
reviewed
Jul 24, 2025
squeek502
reviewed
Jul 24, 2025
h57624paen
force-pushed
the
fix-win-spawn-double-normalize
branch
from
be3c8b3 to
6019633
Compare
h57624paen
commented
Jul 25, 2025
squeek502
reviewed
Jul 25, 2025
squeek502
reviewed
Jul 25, 2025
squeek502
reviewed
Jul 25, 2025
squeek502
reviewed
Jul 25, 2025
besides simply being redundant work, the now removed normalize call would cause spawn to errantly fail (BadPath) when passing a relative path which traversed 'above' the current working directory. This case is already handled by leaving normalization to the windows.wToPrefixedFileW call in windowsCreateProcessPathExt
Also check that FileNotFound is consistently returned when the path is missing.
The new `run_relative` step will test spawning paths like:
child_path: ../84385e7e669db0967d7a42765011dbe0/child
missing_child_path: ../84385e7e669db0967d7a42765011dbe0/child_intentionally_missing
h57624paen
force-pushed
the
fix-win-spawn-double-normalize
branch
from
6019633 to
0f41063
Compare
squeek502
approved these changes
Jul 26, 2025
There was a problem hiding this comment.
Looking good!
For context to those reviewing, the normalizePath calls that are being removed were an artifact of the Windows ChildProcess rework in #13993 coming before #15768 which made the normalizePath calls obsolete.
This PR removes the obsolete normalization and adds tests to check that behavior didn't regress.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
besides simply being redundant work, the now removed normalize call would cause spawn to errantly fail (BadPath) when passing a relative path which traversed 'above' the current working directory. This case is already handled by leaving normalization to the windows.wToPrefixedFileW call in windowsCreateProcessPathExt