Language and variables fix #462
Conversation
… camelcase to match global styles
This reverts commit e0c199f.
|
I did start with updating RXJS but reversed it as I do not have enough knowledge yet to update 659, sorry! |
|
Sorry I think I clicked merge too early (it's been a long time since last PR) |
| * Emits when and if the scanner is autoStarted. | ||
| */ | ||
| @Output() | ||
| autostarted: EventEmitter<void>; |
There was a problem hiding this comment.
That's a breaking change (public API).. Even though it looks better with the uppercase "S" I suggest to revert it
There was a problem hiding this comment.
no problem, I'll push a change and revert the variable. Should have thought about that. Thanks!
|
Much appreciated, thanks! |
|
Let me know if this is good. Pushed up the changes and reverted the variable |
| */ | ||
| @Output() | ||
| autostarting: EventEmitter<boolean>; | ||
| autoStarting: EventEmitter<boolean>; |
There was a problem hiding this comment.
Sorry, I think that is the Problem with the API. this should be "autostarting" again.
| set isAutostarting(state: boolean) { | ||
| this._isAutostarting = state; | ||
| this.autostarting.next(state); | ||
| set isAutoStarting(state: boolean) { |
There was a problem hiding this comment.
Aalso this and the getter below
|
okay that should do it for putting them all back to the originals. Sorry about that! |
| } | ||
|
|
||
| if (this.isAutostarting) { | ||
| if (this.iAutostarting) { |
There was a problem hiding this comment.
there is an "s" missing.. "isAu.." and not "iAu"..
Sorry for all the inconvenience 😅
There was a problem hiding this comment.
ahhhhh! Sorry, I should have stashed my changes and started fresh. Okay, pushed up another.
2 participants
This is literally my first PR on an open source project in a long time. Hope this is the required information!
-- Changes --
this.camerasNotFound.next(null)