Skip to content

Upgrade dependencies for Angular 20 #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 18, 2025
Merged

Upgrade dependencies for Angular 20 #588

merged 2 commits into from
Jun 18, 2025

Conversation

sondreb
Copy link
Contributor

@sondreb sondreb commented May 30, 2025

npm run build and npm run test appears to run just fine. Maybe someone can do more testing?

@sondreb
Copy link
Contributor Author

sondreb commented May 30, 2025

Closes #587

@Angelinsky7
Copy link
Contributor

@sondreb thanks

@MariusGerhard
Copy link

Thank you

@se-wolf
Copy link

se-wolf commented Jun 18, 2025

Thank you!

se-wolf
se-wolf approved these changes Jun 18, 2025
View reviewed changes
Copy link

@se-wolf se-wolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works.

werthdavid
werthdavid approved these changes Jun 18, 2025
View reviewed changes
Copy link
Member

@werthdavid werthdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@werthdavid werthdavid merged commit ce2d24e into zxing-js:master Jun 18, 2025
1 check passed
@sondreb sondreb deleted the angular-20 branch June 18, 2025 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@werthdavid werthdavid werthdavid approved these changes

+1 more reviewer

@se-wolf se-wolf se-wolf approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sondreb @Angelinsky7 @MariusGerhard @se-wolf @werthdavid