ci: use a shared workflow #1693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avik-pal
force-pushed
the
ap/cleanup_ci
branch
8 times, most recently
from
77be576 to
ea45ee9
Compare
avik-pal
commented
Sep 21, 2025
|
The main motivation apart from reducing redundancy here, is that I am working on a PR to separate the integration testing into separate workflows to avoid the bazillion test deps. It would be nice to not copy around the full workflow |
avik-pal
force-pushed
the
ap/cleanup_ci
branch
3 times, most recently
from
a2ed382 to
385a309
Compare
|
CI seems happy
|
giordano
reviewed
Sep 21, 2025
avik-pal
force-pushed
the
ap/cleanup_ci
branch
from
36cf033 to
9f70508
Compare
giordano
reviewed
Sep 22, 2025
Comment on lines
+93
to
+96
| - name: Prepare build on macOS | ||
| if: ${{ startsWith(inputs.os, 'macOS-') && inputs.localjll }} | ||
| run: | | ||
| echo "SDKROOT=$(xcrun --show-sdk-path)" >> "${GITHUB_ENV}" |
There was a problem hiding this comment.
How's this used? Is that picked up automatically by Bazel? Otherwise this seems to be completely unused.
There was a problem hiding this comment.
not sure. I picked it from the old local jll script. That said the macos local jll has been broken for ages so this might very well be unused
giordano
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.