Skip to content

ci: use a shared workflow #1693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 23, 2025
Merged

ci: use a shared workflow #1693

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
df1d630
ci: use a shared workflow
avik-pal Sep 21, 2025
9131bc7
ci: disable assertions for now
avik-pal Sep 21, 2025
3517085
ci: run tests
avik-pal Sep 21, 2025
62ab553
test: remove unused deps
avik-pal Sep 21, 2025
fc1c459
ci: fix common script
avik-pal Sep 21, 2025
91f660c
ci: fix cache name
avik-pal Sep 21, 2025
9f70508
ci: fix conflicting names + original timeout
avik-pal Sep 21, 2025
c24ec97
ci: apply suggestions from code review
avik-pal Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
158 changes: 12 additions & 146 deletions .github/workflows/CI-localjll.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ on:
branches:
- main
- release-*
tags: '*'
tags: ['*']
paths:
- '.github/workflows/CI-localjll.yml'
- 'deps/**'
Expand All @@ -21,157 +21,23 @@ concurrency:
cancel-in-progress: ${{ startsWith(github.ref, 'refs/pull/') }}

jobs:
test:
name: Julia ${{ matrix.version }} - ${{ matrix.os }} - local libReactant - ${{ github.event_name }}
runs-on: ${{ matrix.os }}
container:
image: ${{ contains(matrix.os, 'linux') && 'ghcr.io/enzymead/reactant-docker-images@sha256:7004a6ebbdd77bd047900b2bffc542e8576864056dc27a9c94d30666d6f7ea01' || '' }}
test-localjll:
strategy:
fail-fast: false
matrix:
version:
- '1.10'
- '1.11'
- "1.10"
- "1.11"
os:
- linux-x86-n2-32
- macOS-latest
exclude:
- os: macOS-latest
version: '1.10'
steps:
- name: Free Disk Space
uses: jlumbroso/free-disk-space@main
with:
tool-cache: false
if: ${{ startsWith(matrix.os, 'ubuntu-') }}
- name: Clean `/opt`
run: sudo rm -rf /opt/*
if: ${{ startsWith(matrix.os, 'ubuntu-') }}
- uses: actions/checkout@v5
- name: Set and create TMPDIR
# We have to use `${GITHUB_WORKSPACE}` instead of `github.workspace` because GitHub
# is terrible and the two don't match inside containers:
# https://github.com/actions/runner/issues/2058
run: |
export TMPDIR="${GITHUB_WORKSPACE}/tmp"
echo "TMPDIR=${TMPDIR}" >> "${GITHUB_ENV}"

mkdir -pv "${TMPDIR}"
- uses: julia-actions/setup-julia@v2
with:
version: ${{ matrix.version }}
- name: Load Julia packages from cache
id: julia-cache
uses: julia-actions/cache@v2
- uses: bazel-contrib/[email protected]
name: Set up Bazel
with:
# Avoid downloading Bazel every time.
bazelisk-cache: true
# Store build cache per workflow.
disk-cache: ${{ github.workflow }}-${{ matrix.os }}-${{ matrix.version }}
# Share repository cache between workflows.
repository-cache: true
bazelisk-version: 1.x
- name: Prepare build on macOS
if: ${{ startsWith(matrix.os, 'macOS-') }}
run: |
echo "SDKROOT=$(xcrun --show-sdk-path)" >> "${GITHUB_ENV}"
- name: Install numpy
if: ${{ startsWith(matrix.os, 'macOS-') }}
run: |
python -m pip install numpy
- name: Build libReactant
timeout-minutes: 120
run: |
julia --color=yes --project=deps -e 'using Pkg; Pkg.instantiate()'
julia --color=yes --project=deps deps/build_local.jl
cp LocalPreferences.toml test/
- name: "Setup Runtime Preferences"
run: |
import Pkg
Pkg.Registry.update()
Pkg.instantiate()
using Preferences
Preferences.set_preferences!("Reactant", "xla_runtime" => "PJRT"; force=true)
shell: julia --color=yes --code-coverage=user --depwarn=yes --project=. {0}
env:
JULIA_PKG_PRECOMPILE_AUTO: 0
- name: "Install Dependencies"
run: |
import Pkg
Pkg.Registry.update()
# Install packages present in subdirectories
dev_pks = Pkg.PackageSpec[]
for path in ("lib/ReactantCore",)
push!(dev_pks, Pkg.PackageSpec(; path))
end
Pkg.develop(dev_pks)
shell: julia --color=yes --code-coverage=user --depwarn=yes --project=. {0}
# Only in Julia v1.10 we need to install `ReactantCore` manually.
if: ${{ matrix.version == '1.10' }}
env:
JULIA_PKG_SERVER_REGISTRY_PREFERENCE: eager
- name: "Run Tests: PJRT"
timeout-minutes: 200
run: |
import Pkg
Pkg.Registry.update()
Pkg.test(; coverage="user")
shell: julia --color=yes --code-coverage=user --depwarn=yes --project=. {0}
env:
JULIA_PKG_SERVER_REGISTRY_PREFERENCE: eager
XLA_FLAGS: "--xla_force_host_platform_device_count=12"
JULIA_DEBUG: "Reactant,Reactant_jll"
- name: Upload MLIR modules (PJRT)
uses: actions/upload-artifact@v4
timeout-minutes: 10
if: ${{ always() }}
with:
name: "mlir-localjll-PJRT-${{ matrix.version }}-${{ matrix.os }}-${{ github.event_name }}"
path: "**/*.mlir"
retention-days: 90
overwrite: false
- name: "Setup Runtime Preferences"
run: |
import Pkg
Pkg.Registry.update()
Pkg.instantiate()
using Preferences
Preferences.set_preferences!("Reactant", "xla_runtime" => "IFRT"; force=true)
shell: julia --color=yes --code-coverage=user --depwarn=yes --project=. {0}
env:
JULIA_PKG_PRECOMPILE_AUTO: 0
- name: "Run Tests: IFRT"
timeout-minutes: 200
run: |
import Pkg
Pkg.Registry.update()
Pkg.test(; coverage="user")
shell: julia --color=yes --code-coverage=user --depwarn=yes --project=. {0}
env:
JULIA_PKG_SERVER_REGISTRY_PREFERENCE: eager
XLA_FLAGS: "--xla_force_host_platform_device_count=12"
JULIA_DEBUG: "Reactant,Reactant_jll"
- name: Upload MLIR modules (IFRT)
uses: actions/upload-artifact@v4
timeout-minutes: 10
if: ${{ always() }}
with:
name: "mlir-localjll-IFRT-${{ matrix.version }}-${{ matrix.os }}-${{ github.event_name }}"
path: "**/*.mlir"
retention-days: 90
overwrite: false
- name: Save Julia depot cache on cancel or failure
id: julia-cache-save
if: cancelled() || failure()
uses: actions/cache/save@v4
with:
path: |
${{ steps.julia-cache.outputs.cache-paths }}
key: ${{ steps.julia-cache.outputs.cache-key }}
- uses: julia-actions/julia-processcoverage@v1
- uses: codecov/codecov-action@v5
with:
files: lcov.info
token: ${{ secrets.CODECOV_TOKEN }}
version: "1.10"
uses: ./.github/workflows/CommonCI.yml
with:
julia_version: ${{ matrix.version }}
os: ${{ matrix.os }}
runtime: "both"
assertions: false
localjll: true
184 changes: 51 additions & 133 deletions .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ on:
branches:
- main
- release-*
tags: "*"
tags: ["*"]
paths:
- ".github/workflows/CI.yml"
- "ext/**"
Expand All @@ -30,11 +30,6 @@ concurrency:

jobs:
test:
timeout-minutes: 90
name: Julia ${{ matrix.version }} - ${{ matrix.test_group }} - ${{ matrix.os }} - ${{ matrix.runtime }} - assertions=${{ matrix.assertions }} - ${{ github.event_name }}
runs-on: ${{ matrix.os }}
container:
image: ${{ contains(matrix.os, 'linux') && 'ghcr.io/enzymead/reactant-docker-images:main' || '' }}
strategy:
fail-fast: false
matrix:
Expand All @@ -52,137 +47,60 @@ jobs:
# - macOS-13
- macOS-latest
- windows-latest
- linux-x86-ct6e-180-4tpu
test_group:
- core
- neural_networks
- integration
runtime:
- "PJRT"
- "IFRT"
assertions:
- false
include:
- "pjrt"
- "ifrt"
exclude:
- os: linux-x86-ct6e-180-4tpu
version: "1.11"
assertions: false
test_group: core
runtime: "IFRT"
- os: linux-x86-ct6e-180-4tpu
version: "1.11"
assertions: false
test_group: integration
runtime: "IFRT"
- os: linux-x86-ct6e-180-4tpu
version: "1.11"
assertions: false
test_group: neural_networks
runtime: "IFRT"
- os: ubuntu-24.04
version: "1.10"
assertions: true
test_group: core
runtime: "PJRT"
- os: ubuntu-24.04
version: "1.10"
assertions: true
test_group: neural_networks
runtime: "PJRT"
- os: ubuntu-24.04
version: "1.10"
assertions: true
test_group: integration
runtime: "PJRT"
- os: ubuntu-24.04
libReactant: packaged
version: '1.10'
test_group: core
- os: ubuntu-24.04
libReactant: packaged
version: '1.10'
test_group: neural_networks
- os: ubuntu-24.04
libReactant: packaged
version: '1.10'
test_group: integration
steps:
- name: Set TMPDIR
# We have to use `${GITHUB_WORKSPACE}` instead of `github.workspace` because GitHub
# is terrible and the two don't match inside containers:
# https://github.com/actions/runner/issues/2058

if: ${{ matrix.os != 'windows-latest' }}
run: |
echo "TMPDIR=${GITHUB_WORKSPACE}/tmp" >> ${GITHUB_ENV}
- uses: actions/checkout@v5
- name: Create TMPDIR
if: ${{ matrix.os != 'windows-latest' }}
run: |
mkdir -p ${{ env.TMPDIR }}
- uses: julia-actions/setup-julia@v2
if: ${{ ! matrix.assertions }}
with:
version: ${{ matrix.version }}
- uses: julia-actions/cache@v2
- uses: actions/checkout@v5
if: ${{ matrix.assertions }}
with:
repository: "JuliaLang/julia"
ref: release-${{ matrix.version }}
path: "julia"
- name: Compile Julia
if: ${{ matrix.assertions }}
run: |
sed -i.bak 's/exit 2/exit 0/g' julia/deps/tools/jlchecksum
make -C julia -j $(nproc) FORCE_ASSERTIONS=1 LLVM_ASSERTIONS=1 JULIA_PRECOMPILE=0
echo $PWD/julia/usr/bin >> $GITHUB_PATH
- name: "Setup Runtime Preferences"
uses: "DamianReeves/write-file-action@master"
with:
path: "LocalPreferences.toml"
write-mode: "overwrite"
contents: |
[Reactant]
xla_runtime = "${{ matrix.runtime }}"
- name: "Install Dependencies"
run: |
import Pkg
Pkg.Registry.update()
# Install packages present in subdirectories
dev_pks = Pkg.PackageSpec[]
for path in ("lib/ReactantCore",)
push!(dev_pks, Pkg.PackageSpec(; path))
end
Pkg.develop(dev_pks)
shell: julia --color=yes --code-coverage=user --depwarn=yes --project=. {0}
# Only in Julia v1.10 we need to install `ReactantCore` manually.
if: ${{ matrix.version == '1.10' }}
env:
JULIA_PKG_SERVER_REGISTRY_PREFERENCE: eager
- name: "Run Tests"
timeout-minutes: 60
run: |
import Pkg
Pkg.Registry.update()
Pkg.test(; coverage="user")
shell: julia --color=yes --code-coverage=user --depwarn=yes --project=. {0}
id: run_tests
env:
JULIA_PKG_SERVER_REGISTRY_PREFERENCE: eager
ENABLE_PJRT_COMPATIBILITY: 1
REACTANT_TEST_GROUP: ${{ matrix.test_group }}
XLA_FLAGS: "--xla_force_host_platform_device_count=12"
JULIA_DEBUG: "Reactant,Reactant_jll"
- name: Upload MLIR modules
uses: actions/upload-artifact@v4
timeout-minutes: 10
if: ${{ always() }}
with:
name: "mlir-${{ matrix.version }}-${{ matrix.test_group }}-${{ matrix.os }}-${{ matrix.runtime }}-assertions=${{ matrix.assertions }}-${{ github.event_name }}"
path: "**/*.mlir"
retention-days: 90
overwrite: false
- uses: julia-actions/julia-processcoverage@v1
- uses: codecov/codecov-action@v5
with:
files: lcov.info
token: ${{ secrets.CODECOV_TOKEN }}
- os: linux-x86-ct6e-180-4tpu
runtime: "pjrt"
uses: ./.github/workflows/CommonCI.yml
with:
julia_version: ${{ matrix.version }}
os: ${{ matrix.os }}
runtime: ${{ matrix.runtime }}
test_group: ${{ matrix.test_group }}

# This has been broken for a while, originating from CUDA.jl
# test-assertions:
# strategy:
# fail-fast: false
# matrix:
# version:
# - "1.10"
# test_group:
# - core
# - neural_networks
# - integration
# uses: ./.github/workflows/CommonCI.yml
# with:
# julia_version: ${{ matrix.version }}
# os: "ubuntu-24.04"
# runtime: "both"
# assertions: true
# test_group: ${{ matrix.test_group }}

downgrade:
strategy:
fail-fast: false
matrix:
test_group:
- core
- neural_networks
- integration
runtime:
- "pjrt"
- "ifrt"
uses: ./.github/workflows/CommonCI.yml
with:
julia_version: "1.10"
os: "ubuntu-24.04"
runtime: ${{ matrix.runtime }}
test_group: ${{ matrix.test_group }}
downgrade_testing: true
Loading
Loading